Skip to content

add: LSP-bitbake for yocto project#148

Merged
rchl merged 2 commits intosublimelsp:mainfrom
huyhoang8398:add/lsp-bitbake
Mar 5, 2026
Merged

add: LSP-bitbake for yocto project#148
rchl merged 2 commits intosublimelsp:mainfrom
huyhoang8398:add/lsp-bitbake

Conversation

@huyhoang8398
Copy link
Copy Markdown
Contributor

@huyhoang8398 huyhoang8398 commented Mar 4, 2026

Bitbake support for Sublime's LSP plugin provided through VS Code's Bitbake language server extension

To achieve a best result, considering install also my syntax highlighting plugin which is at:
https://github.com/huyhoang8398/BitBake-Syntax

if this MR is approved, i would love to transfer it to sublimelsp and start contributing it there

Copy link
Copy Markdown

@STReviewBot STReviewBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: LSP-bitbake

Packages added:
  - LSP-bitbake

Processing package "LSP-bitbake"
  - All checks passed

@jwortmann
Copy link
Copy Markdown
Member

jwortmann commented Mar 4, 2026

The res URI scheme is for files in .sublime-package archives which can be opened via "View Package File" command. I think the only file types where this should be relevant are Python and JSON (maybe XML too). Are you sure that you need that scheme for files with source.bb scope?

The JSON schema contains the definition for a "LSP-html" property in project settings. And the Python code has class definitions with references to things like html/customDataChanged...
Are you sure that is applicable to your language server?

@huyhoang8398
Copy link
Copy Markdown
Contributor Author

The res URI scheme is for files in .sublime-package archives which can be opened via "View Package File" command. I think the only file types where this should be relevant are Python and JSON (maybe XML too). Are you sure that you need that scheme for files with source.bb scope?

The JSON schema contains the definition for a "LSP-html" property in project settings. And the Python code has class definitions with references to things like html/customDataChanged... Are you sure that is applicable to your language server?

thanks for suggestion, i took the template/example of LSP-html as starting point, i will make some cleanup

@rchl
Copy link
Copy Markdown
Member

rchl commented Mar 4, 2026

The repo was transferred to https://github.com/sublimelsp/LSP-bitbake.

I've also mentioned some of those issues + some more.

Would suggest changing this over-engineered structure to a single plugin.py file like in https://github.com/sublimelsp/LSP-dockerfile/blob/master/plugin.py for example.

And since the server is a published package, remove all files but package.json and package-lock.json from its directory and update renovate.json to not ignore npm updates.

@rchl
Copy link
Copy Markdown
Member

rchl commented Mar 4, 2026

Also update readme to include info about required syntax since without it the server won't start.

Can get inspiration from https://github.com/sublimelsp/LSP-dockerfile/blob/master/README.md maybe

@huyhoang8398
Copy link
Copy Markdown
Contributor Author

@rchl @jwortmann thanks for suggestion, i have refractor it to use a much simpler architure with sublimelsp/LSP-bitbake#2

Copy link
Copy Markdown

@STReviewBot STReviewBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: LSP-bitbake

Packages added:
  - LSP-bitbake

Processing package "LSP-bitbake"
  - All checks passed

@huyhoang8398
Copy link
Copy Markdown
Contributor Author

should be merge this also? since sublimelsp/LSP-bitbake#2 was merged

@rchl rchl requested a review from STReviewBot March 5, 2026 19:25
Copy link
Copy Markdown

@STReviewBot STReviewBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: LSP-bitbake

Packages added:
  - LSP-bitbake

Processing package "LSP-bitbake"
  - All checks passed

@rchl rchl merged commit a04bc23 into sublimelsp:main Mar 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants